Remove skipping preprocessed files based on the filename#1486
Merged
daneshk merged 9 commits intoballerina-platform:masterfrom Jun 19, 2025
Merged
Remove skipping preprocessed files based on the filename#1486daneshk merged 9 commits intoballerina-platform:masterfrom
daneshk merged 9 commits intoballerina-platform:masterfrom
Conversation
daneshk
requested review from
DimuthuMadushan,
MohamedSabthar,
ThisaruGuruge and
shafreenAnfar
as code owners
ThisaruGuruge
previously approved these changes
Jun 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1486 +/- ##
============================================
+ Coverage 83.38% 83.48% +0.10%
+ Complexity 341 338 -3
============================================
Files 37 37
Lines 1631 1629 -2
Branches 239 238 -1
============================================
Hits 1360 1360
+ Misses 170 165 -5
- Partials 101 104 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nuvindu
reviewed
Jun 18, 2025
Nuvindu
reviewed
Jun 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the logic that skips files with the same name so that the FTP listener will reprocess them, updates test setup to use separate “in”/“out” directories, and bumps the module version to 2.13.2.
- Initialize
inandoutfolders in the mock SFTP server - Drop the
processed.contains(path)check to allow reprocessing same-named files - Update tests and configuration to use
/inand/outpaths and bump version
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test-utils/src/main/java/.../MockFtpServer.java | Create in/out directories on startup |
| native/src/main/java/.../RemoteFileSystemConsumer.java | Remove processed-path skip logic |
| changelog.md | Add unreleased entry for same-name fix |
| ballerina/tests/secure_listener_endpoint_with_caller_test.bal | Adjust tests to new /in/out directory flow |
| ballerina/Dependencies.toml | Bump package version to 2.13.2 |
| ballerina/CompilerPlugin.toml | Update compiler plugin path to 2.13.2-SNAPSHOT |
| ballerina/Ballerina.toml | Align module version and native jar snapshot |
Comments suppressed due to low confidence (2)
changelog.md:6
- [nitpick] Align the "unreleased" header with Keep a Changelog conventions, for example use "## [Unreleased]".
## unreleased
native/src/main/java/io/ballerina/stdlib/ftp/transport/server/RemoteFileSystemConsumer.java:225
- Since the skip logic is removed, consider deleting the
processedcollection and any related unused fields or imports to clean up dead code.
String path = file.getName().getURI();
test-utils/src/main/java/io/ballerina/stdlib/ftp/testutils/mockServerUtils/MockFtpServer.java
Show resolved
Hide resolved
Co-authored-by: Nuvindu Nirmana <63797478+Nuvindu@users.noreply.github.com>
|
Nuvindu
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#8035
Addresses the issue of FTP listener not processing files with the same name.
Examples
Checklist